Repository navigation
fix(cli): drop wrangler's "(custom domain)" note from deployed URLs - #52
Merged
Merged
Conversation
Wrangler lists a custom domain target as "cloudhal.com (custom domain)"; deployedUrls turned it into "https://cloudhal.com (custom domain)". A fresh checkout (Workers Builds) then parsed it with new URL() to set the site's domain and failed with "Invalid URL" after both Workers had deployed. Found on cloudhal.com's first CI deploy. Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: Madraka <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cloudhal.com's first Workers Builds deploy shipped both Workers, then failed with
cloudhal: Invalid URL: wrangler reports a custom domain target ascloudhal.com (custom domain),deployedUrlsmade ithttps://cloudhal.com (custom domain), andafterDeployrannew URL()on it because a fresh checkout's local site has no domains yet. Any deploy-button site with a custom domain would hit it.deployedUrlsnow keeps the hostname only. Test:packages/cli/test/deployed-urls.test.ts. Changeset:@cloudhal/clipatch.🤖 Generated with Claude Code